fix(models): create immutable defaults per instance - #113
Draft
marlon-costa-dc wants to merge 1 commit into
Draft
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Root cause
Pydantic deep-copied shared MappingProxyType defaults while constructing a failed PipelineStageResult, raising cannot pickle mappingproxy and hiding the original stage failure. A callable PrivateAttr default also acted as a descriptor and ignored the typed test consumer override.
Change
Evidence so far
Remaining before ready: deps check, generation check/idempotence, CI-mode tests.
Summary by cubic
Fixes model defaults so failed pipeline stages report their real error instead of a
cannot pickle mappingproxyexception. Pydantic's deep copy of the sharedMappingProxyTypedefaults masked the original stage failure.getpass.getpassin a non-descriptor callable so the typed password reader override is applied.Written for commit c0e6fcb. Summary will update on new commits.